> -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > Sent: Friday, May 5, 2023 4:04 PM > To: Bharat Bhushan <bbhushan2@xxxxxxxxxxx>; wim@xxxxxxxxxxxxxxxxxx; > linux@xxxxxxxxxxxx; robh+dt@xxxxxxxxxx; krzysztof.kozlowski+dt@xxxxxxxxxx; > linux-watchdog@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx > Subject: Re: [EXT] Re: [PATCH 1/2 v5] dt-bindings: watchdog: marvell GTI system > watchdog driver > > On 05/05/2023 09:55, Bharat Bhushan wrote: > >>>>> Different platform have different number of GTI timers, for > >>>>> example some > >>>> platform have total 64 timer and other have 32 timers. > >>>>> So which GTI timer will be used for watchdog will depend on > >>>>> platform. So > >>>> added this property to enable this driver on platforms. > >>>> > >>>> This should be deducted from compatible. > >>> > >>> If I understood correctly, we should add different compatible for > >>> each soc and > >> use same to get the information we tried to get using "wdt-timer-index" > >> property, is that correct? > >>> > >>> But each series have many socs (10s) and GTI hardware is same except > >>> number > >> of timers they supports, so should we add that many compatibles or > >> add a property like this? > >> > >> Same story every time... and was discussed many, many times on the lists. > >> > >> https://urldefense.proofpoint.com/v2/url?u=https- > >> 3A__elixir.bootlin.com_linux_v6.1- > >> 2Drc1_source_Documentation_devicetree_bindings_writing-2Dbindings.rst > >> - > 23L42&d=DwICaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=PAAlWswPe7d8gHlGbCLmy > >> > 2YezyK7O3Hv_t2heGnouBw&m=3aeejmHQ5C8TyLM5odlaq6KnLYHt4PhpJp70FQa > >> qbNf7w15KFHA3fmeDR2V-en4m&s=FKeW5tpOG- > >> CJoV_JKuqTa0k_tRrYWAQZG1UfqlW3c74&e= > >> > >> You need anyway SoC specific compatibles. Once you add proper > >> compatibles, you will see that property is not needed. > > > > Also on a given soc, firmware can configure one of 64 timer to be used as > system watchdog time then compatible will not work. > > Can't you query the firmware for that? Or can't you just choose first unused > timer? DT is for non-discoverable properties. Query to firmware required arm SMC call, to me that does not look correct approach. Thought of using first one but that is already used and moving that is as same as this. Hardcoding to 63 will make it work on some SoCs but not all. Thanks -Bharat > > Best regards, > Krzysztof
