On 03/05/2023 14:10, Bharat Bhushan wrote: > Add binding documentation for the Marvell GTI system > watchdog driver. > > Signed-off-by: Bharat Bhushan <bbhushan2@xxxxxxxxxxx> > --- > v5: > - Added wdt-timer-index property I did not ask for it... > - Get clock frequency from clocks/clock-name device tree property Where? It's not possible in current code. I don't think you tested this at all. > > .../bindings/watchdog/marvell,gti-wdt.yaml | 54 +++++++++++++++++++ > 1 file changed, 54 insertions(+) > create mode 100644 Documentation/devicetree/bindings/watchdog/marvell,gti-wdt.yaml > > diff --git a/Documentation/devicetree/bindings/watchdog/marvell,gti-wdt.yaml b/Documentation/devicetree/bindings/watchdog/marvell,gti-wdt.yaml > new file mode 100644 > index 000000000000..e3315653f961 > --- /dev/null > +++ b/Documentation/devicetree/bindings/watchdog/marvell,gti-wdt.yaml > @@ -0,0 +1,54 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/watchdog/marvell,gti-wdt.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Marvell Global Timer (GTI) system watchdog > + > +allOf: > + - $ref: watchdog.yaml# > + > +maintainers: > + - Bharat Bhushan <bbhushan2@xxxxxxxxxxx> > + > +properties: > + compatible: > + const: marvell,gti-wdt > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + wdt-timer-index: missing vendor prefix missing type > + maxItems: 1 ??? > + description: > + This contains the timer number out of total 64 timers supported > + by GTI hardware block. Why do you need it? What does it represent? We do not keep indices of devices other than something in reg, so please justify why exception must be made here. > + > +required: > + - compatible > + - reg > + - interrupts > + - wdt-timer-index > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/irq.h> > + soc { > + #address-cells = <2>; > + #size-cells = <2>; > + > + watchdog@802000040000 { > + compatible = "marvell,gti-wdt"; > + reg = <0x00008020 0x00040000 0x00000000 0x00020000>; > + interrupts = <0 38 IRQ_TYPE_EDGE_RISING>; Use defines for flags. > + wdt-timer-index = <63>; Best regards, Krzysztof
