On Mon, May 10, 2021 at 04:44:21PM +0800, Shaokun Zhang wrote: > >>> +static void sbsa_gwdt_reg_write(u64 val, struct sbsa_gwdt *gwdt) > >> > >> What is the point of making val an u64 variable ? Without changing > > > > Oops, unsigned int is enough. > > > > Sorry, it shall be 'u64', because it is the value that clock * timeout > and will be written to WOR register which is 64-bit register in > architecture version 1. > As I have been trying to point out, that won't really happen unless max_hw_heartbeat_ms is adjusted. The register may be a 64 bit register, and the variable may be a 64-bit variable, but that doesn't make the value passed in that variable larger than 32 bit unless the code is in place to actually do that. Guenter
