On 8/7/2020 9:21 AM, Guenter Roeck wrote: > On Fri, Aug 07, 2020 at 04:59:02PM +0530, madhuparnabhowmik10@xxxxxxxxx wrote: >> From: Madhuparna Bhowmik <madhuparnabhowmik10@xxxxxxxxx> >> >> In rdc321x_wdt_probe(), rdc321x_wdt_device.queue is initialized >> after misc_register(), hence if ioctl is called before its >> initialization which can call rdc321x_wdt_start() function, >> it will see an uninitialized value of rdc321x_wdt_device.queue, >> hence initialize it before misc_register(). >> Also, rdc321x_wdt_device.default_ticks is accessed in reset() >> function called from write callback, thus initialize it before >> misc_register(). >> >> Found by Linux Driver Verification project (linuxtesting.org). >> >> Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10@xxxxxxxxx> > > Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx> > > Having said that ... this is yet another potentially obsolete driver. > You are really wasting your (and, fwiw, my) time. > > Florian, any thoughts if support for this chip can/should be deprecated > or even removed ? I am still using my rdc321x-based SoC, so no, this is not obsolete as far as I am concerned, time permitting, modernizing the driver is on my TODO after checking/fixing the Ethernet driver first. Reviewed-by: Florian Fainelli <f.fainelli@xxxxxxxxx> -- Florian
