On Wed, 2020-07-29 at 15:42 +0800, Matthias Brugger wrote: > Hi Crystal, > > On 29/07/2020 08:30, Crystal Guo wrote: > > merge all the reset numbers in one head file. > > > > Signed-off-by: Crystal Guo <crystal.guo@xxxxxxxxxxxx> > > --- > > include/dt-bindings/reset-controller/mtk-resets.h | 13 +++++++++++++ > > 1 file changed, 13 insertions(+) > > create mode 100644 include/dt-bindings/reset-controller/mtk-resets.h > > > > diff --git a/include/dt-bindings/reset-controller/mtk-resets.h b/include/dt-bindings/reset-controller/mtk-resets.h > > new file mode 100644 > > index 0000000..d73a4ba > > --- /dev/null > > +++ b/include/dt-bindings/reset-controller/mtk-resets.h > > @@ -0,0 +1,13 @@ > > +/* SPDX-License-Identifier: GPL-2.0 */ > > +/* > > + * Copyright (C) 2020 Mediatek Inc. > > + * > > + */ > > + > > +#ifndef _DT_BINDINGS_RESET_CONTROLLER_MTK > > +#define _DT_BINDINGS_RESET_CONTROLLER_MTK > > + > > +#define MT2712_TOPRGU_SW_RST_NUM 11 > > +#define MT8183_TOPRGU_SW_RST_NUM 19 > > Maybe I didn't explain myself properly. We want to have all resets in one file > and do not want to have the resets for the watchdog in a different file. That > means I don't thin your patch is correct and the effort should be abandoned. > > Regards, > Matthias Do you mean to keep the current way unchanged? For example, with a new SOC 8192, should add a new head file mt8192_resets.h for the resets numbers.
