On Mon, Aug 19, 2019 at 07:23:09PM -0500, Corey Minyard wrote: > On Mon, Aug 19, 2019 at 03:43:45PM -0700, Guenter Roeck wrote: > > On Mon, Aug 19, 2019 at 03:37:01PM -0500, minyard@xxxxxxx wrote: > > > From: Corey Minyard <cminyard@xxxxxxxxxx> > > > > > > This is for the read data pretimeout governor. > > > > > > Signed-off-by: Corey Minyard <cminyard@xxxxxxxxxx> > > > > On further thought, I think it would be a bad idea to add this > > functionality: It changes the userspace ABI for accessing the watchdog > > device. Today, when a watchdog device is opened, it does not provide > > read data, it does not hang, and returns immediately. A "cat" from it > > is an easy and quick means to test if a watchdog works. > > Umm, why would a "cat" from a watchdog tell you if a watchdog works? cat /dev/watchdog starts the watchdog running. Then one can do useful things like monitor /sys/class/watchdog/watchdogN and see time ticking down, etc.., echo V > /dev/watchdog stops the watchdog assuming driver supports WDIOF_MAGICCLOSE. So I can test without having to reboot. One can't test magic close with the proposed change as /dev/watchdog is exclusive open. -- ----------------------------------------------------------------------------- Jerry Hoemann Software Engineer Hewlett Packard Enterprise -----------------------------------------------------------------------------
