Re: [PATCH 04/12] watchdog: Allow pretimeout governor setting to be accessed from modules

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 19, 2019 at 03:37:03PM -0500, minyard@xxxxxxx wrote:
> From: Corey Minyard <cminyard@xxxxxxxxxx>
> 
> This is so watchdog driver (like IPMI) can set it.
> 
> Signed-off-by: Corey Minyard <cminyard@xxxxxxxxxx>
> ---
>  drivers/watchdog/watchdog_pretimeout.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/watchdog/watchdog_pretimeout.c b/drivers/watchdog/watchdog_pretimeout.c
> index b45041b0ef39..270baf7b3fa0 100644
> --- a/drivers/watchdog/watchdog_pretimeout.c
> +++ b/drivers/watchdog/watchdog_pretimeout.c
> @@ -95,6 +95,7 @@ int watchdog_pretimeout_governor_set(struct watchdog_device *wdd,
>  
>  	return 0;
>  }
> +EXPORT_SYMBOL_GPL(watchdog_pretimeout_governor_set);
>  

I don't think that is a good idea. The whole point of pretimeout governor
selection was to be able to configure it from userspace.

>  void watchdog_notify_pretimeout(struct watchdog_device *wdd)
>  {
> -- 
> 2.17.1
> 



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux