On Tue, Feb 13, 2018 at 09:07:25AM -0800, Guenter Roeck wrote: > On Sun, Feb 11, 2018 at 10:21:11PM -0700, Jerry Hoemann wrote: > > Update driver version number to reflect changes. > > > > Signed-off-by: Jerry Hoemann <jerry.hoemann@xxxxxxx> > > --- > > drivers/watchdog/hpwdt.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c > > index bb0dcc8709b8..78168e2f9b4e 100644 > > --- a/drivers/watchdog/hpwdt.c > > +++ b/drivers/watchdog/hpwdt.c > > @@ -23,7 +23,7 @@ > > > > #include <asm/nmi.h> > > > > -#define HPWDT_VERSION "1.4.0" > > +#define HPWDT_VERSION "2.0.0" > > I would suggest to drop the version entirely. History and experience shows > that it is not really useful. > > Guenter > HPE can and does replace drivers w/o updating the underlying kernel version. So having driver print its version has been very useful to me in debugging issues in other drivers. I want to maintain that in here. > > #define SECS_TO_TICKS(secs) ((secs) * 1000 / 128) > > #define TICKS_TO_SECS(ticks) ((ticks) * 128 / 1000) > > #define HPWDT_MAX_TIMER TICKS_TO_SECS(65535) > > -- > > 2.13.6 > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in > > the body of a message to majordomo@xxxxxxxxxxxxxxx > > More majordomo info at http://vger.kernel.org/majordomo-info.html -- ----------------------------------------------------------------------------- Jerry Hoemann Software Engineer Hewlett Packard Enterprise ----------------------------------------------------------------------------- -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
