On Tue, Feb 13, 2018 at 10:20:42AM -0800, Guenter Roeck wrote: > On Sun, Feb 11, 2018 at 10:21:10PM -0700, Jerry Hoemann wrote: > > The intent of this parameter is unclear and it sets up a > > race between the reset of the system by ASR and crashdump. > > > > The length of time between receipt of the pretimeout NMI > > and the ASR reset of the system is fixed by hardware. > > > > Turning the parameter off doesn't necessairly prevent a crash dump. > > Also, having the ASR reset occur while the system is crash dumping > > doesn't imply that the dump was hung given the short duration > > between the NMI and the reset. > > > > This parameter is not a substitute for having a architected watchdog > > crashdump hang detection paridigm. > > > > Signed-off-by: Jerry Hoemann <jerry.hoemann@xxxxxxx> > > --- > > drivers/watchdog/hpwdt.c | 7 +------ > > 1 file changed, 1 insertion(+), 6 deletions(-) > > > > diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c > > index e9e54fe20804..bb0dcc8709b8 100644 > > --- a/drivers/watchdog/hpwdt.c > > +++ b/drivers/watchdog/hpwdt.c > > @@ -33,7 +33,6 @@ > > static unsigned int soft_margin = DEFAULT_MARGIN; /* in seconds */ > > static bool nowayout = WATCHDOG_NOWAYOUT; > > #ifdef CONFIG_HPWDT_NMI_DECODING > > -static unsigned int allow_kdump = 1; > > At the end of hpwdt_init_nmi_decoding(), there used to be a log message > showing the value of allow_kdump. Maybe that was removed in another patch, > but it really belongs to this patch, or am I missing something ? > > Guenter That got pulled into patch 6. I'll refactor the patches to include the message change here. -- ----------------------------------------------------------------------------- Jerry Hoemann Software Engineer Hewlett Packard Enterprise ----------------------------------------------------------------------------- -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
