Hi Guenter, On 2017/12/27 1:28, Guenter Roeck wrote: > On Sat, Dec 23, 2017 at 07:01:37PM +0800, Yisheng Xie wrote: >> > Default ioremap is ioremap_nocache, so devm_ioremap has the same >> > function with devm_ioremap_nocache, which can just be killed to >> > save the size of devres.o >> > >> > This patch is to use use devm_ioremap instead of devm_ioremap_nocache, >> > which should not have any function change but prepare for killing >> > devm_ioremap_nocache. >> > > I don't have issues with the patch itself - on mips, the definitions > _are_ the same - but with the description. It is not universally correct > that the definitions are the same. Please update and resubmit. > Right, there are 4 archs have different meaning of ioremap. And presently, I still do not know why. For this patch itself, maybe I can update and resubmit. Thanks and Merry Christmas. Yisheng > Guenter > -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html