Re: [v4,2/2] watchdog: xen_wdt: remove info message and version number

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Nov 15, 2017 at 07:34:42PM +0000, Radu Rendec wrote:
> The initial info message (early in the xen_wdt_init_module() function)
> is not very useful and we already have a message on successful probe. If
> the probe fails, additional messages are printed anyway.
> 
> The version number serves no useful purpose and it ran out of favor
> upstream anyway.
> 
> Signed-off-by: Radu Rendec <rrendec@xxxxxxxxxx>

Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>

> ---
>  drivers/watchdog/xen_wdt.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/watchdog/xen_wdt.c b/drivers/watchdog/xen_wdt.c
> index 51576e15a086..f1c016d015b3 100644
> --- a/drivers/watchdog/xen_wdt.c
> +++ b/drivers/watchdog/xen_wdt.c
> @@ -10,7 +10,6 @@
>   */
>  
>  #define DRV_NAME	"xen_wdt"
> -#define DRV_VERSION	"0.01"
>  
>  #include <linux/bug.h>
>  #include <linux/errno.h>
> @@ -189,8 +188,6 @@ static int __init xen_wdt_init_module(void)
>  	if (!xen_domain())
>  		return -ENODEV;
>  
> -	pr_info("Xen WatchDog Timer Driver v%s\n", DRV_VERSION);
> -
>  	err = platform_driver_register(&xen_wdt_driver);
>  	if (err)
>  		return err;
> @@ -216,5 +213,4 @@ module_exit(xen_wdt_cleanup_module);
>  
>  MODULE_AUTHOR("Jan Beulich <jbeulich@xxxxxxxxxx>");
>  MODULE_DESCRIPTION("Xen WatchDog Timer Driver");
> -MODULE_VERSION(DRV_VERSION);
>  MODULE_LICENSE("GPL");
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux