On Fri, Nov 17, 2017 at 3:22 PM, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > There is no need to #define the license of the driver, just put it in > the MODULE_LICENSE() line directly as a text string. > > This allows tools that check that the module license matches the source > code license to work properly, as there is no need to unwind the > unneeded dereference, especially when it is defined just a few lines > above from where it is used. > > Cc: Wim Van Sebroeck <wim@xxxxxxxxx> > Cc: Guenter Roeck <linux@xxxxxxxxxxxx> > Reported-by: Philippe Ombredanne <pombredanne@xxxxxxxx> > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> Reviewed-by: Philippe Ombredanne <pombredanne@xxxxxxxx> -- Cordially Philippe Ombredanne -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
