On Mon, 2017-11-06 at 10:04 -0800, Guenter Roeck wrote: > On Mon, Nov 06, 2017 at 05:39:03PM +0000, Radu Rendec wrote: > > I see your point, but I think module_platform_driver_probe() can't be > > used here. The problem is that there's nothing else to create the > > platform device, so if xen_wdt doesn't create it on its own, there will > > be no (matching) platform device to be probed by the driver that > > xen_wdt registers. [snip] > > I already fixed the other issues in the previous patch so, unless you > > think init/exit can be simplified in a different way, I am ready to > > resend the (updated) patches. > > > > Ok; thanks for having a look. You're welcome. Attaching the updated patches. By the way, I tried to replace pr_* with dev_* but then the messages look kind of funny, e.g. wdt wdt: initialized (timeout=60s, nowayout=0) instead of: xen_wdt: initialized (timeout=60s, nowayout=0) I thought this would be more confusing than useful to the user, so I reverted back to pr_*. Thanks, Radu Radu Rendec (2): watchdog: xen_wdt: use the watchdog subsystem watchdog: xen_wdt: remove info message and version number drivers/watchdog/xen_wdt.c | 243 +++++++++------------------------------------ 1 file changed, 49 insertions(+), 194 deletions(-) -- 2.13.6 -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
