On Sat, Oct 28, 2017 at 9:14 AM, Guenter Roeck <linux@xxxxxxxxxxxx> wrote: > On Wed, Oct 25, 2017 at 12:04:20PM -0700, Andrey Smirnov wrote: >> This driver provides access to RAVE SP watchdog functionality. >> >> Cc: linux-kernel@xxxxxxxxxxxxxxx >> Cc: linux-watchdog@xxxxxxxxxxxxxxx >> Cc: cphealy@xxxxxxxxx >> Cc: Lucas Stach <l.stach@xxxxxxxxxxxxxx> >> Cc: Nikita Yushchenko <nikita.yoush@xxxxxxxxxxxxxxxxxx> >> Cc: Lee Jones <lee.jones@xxxxxxxxxx> >> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> >> Cc: Pavel Machek <pavel@xxxxxx> >> Cc: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> >> Cc: Guenter Roeck <linux@xxxxxxxxxxxx> >> Cc: Rob Herring <robh@xxxxxxxxxx> >> Cc: Johan Hovold <johan@xxxxxxxxxx> >> Signed-off-by: Nikita Yushchenko <nikita.yoush@xxxxxxxxxxxxxxxxxx> >> Signed-off-by: Andrey Smirnov <andrew.smirnov@xxxxxxxxx> >> --- >> >> Guenter: >> >> In our previous discussion you noted that relying on the state of >> WDOG_HW_RUNNING was not correct (that should be fixed now), please let >> me know if using watchdog_hw_running() the way I do in >> rave_sp_wdt_set_timeout() is incorrect as well. >> > > You could as well have used watchdog_active(), but it is ok. > That's easy to change. I'll do that in v10. >> Thanks, >> Andrey Smirnov >> >> drivers/watchdog/Kconfig | 7 + >> drivers/watchdog/Makefile | 1 + >> drivers/watchdog/rave-sp-wdt.c | 343 +++++++++++++++++++++++++++++++++++++++++ >> 3 files changed, 351 insertions(+) >> create mode 100644 drivers/watchdog/rave-sp-wdt.c >> > [ ... ] > >> + >> +static int rave_sp_wdt_probe(struct platform_device *pdev) >> +{ >> + struct device *dev = &pdev->dev; >> + const struct of_device_id *id; >> + struct watchdog_device *wdd; >> + struct rave_sp_wdt *sp_wd; >> + struct nvmem_cell *cell; >> + __le16 timeout = 0; >> + int ret; >> + >> + id = of_match_device(rave_sp_wdt_variants, dev->parent); >> + if (WARN_ON(!id)) >> + return -ENODEV; >> + > > I could understand an error message here, but why a traceback ? > I can't think of a good reason for it. I'll change this to a regular error message in v10. Thanks, Andrey Smirnov -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html