Re: [PATCH v3 4/4] watchdog: i6300esb: remove info message and version number

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2017-10-26 at 18:05 -0700, Guenter Roeck wrote:
> On 10/26/2017 09:10 AM, Radu Rendec wrote:
> > The initial info message (early in the esb_probe() function) is not very
> > useful and we already have a message on successful probe, which includes
> > device identification. If the probe fails (e.g. PCI related errors),
> > additional messages are printed anyway.
> > 
> > The version number was only used in the initial info message. Other than
> > that, it serves no useful purpose and it ran out of favor upstream
> > anyway.
> > 
> > Signed-off-by: Radu Rendec <rrendec@xxxxxxxxxx>
> 
> Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> 
> ... and thanks a lot for doing this!

You're welcome. Thanks for reviewing this and for all the input!

We also benefit from this work - on the long run, it's always easier to
work with upstream and get changes accepted than maintain custom
patches.

Best,
Radu

--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux