On Tue, Oct 17, 2017 at 05:30:27PM +0200, Michael Grzeschik wrote:
> In case some application was writing to the watchdog before closing we
> have to ensure that we add enough delay before writing again to the
> DA9062AA_CONTROL_F register. The delay otherwise can only be ensured by
> min_hw_heartbeat_ms for pings.
>
> Signed-off-by: Michael Grzeschik <m.grzeschik@xxxxxxxxxxxxxx>
> ---
> drivers/watchdog/da9062_wdt.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/watchdog/da9062_wdt.c b/drivers/watchdog/da9062_wdt.c
> index 8297bcf0b9f75..1fe88826c6981 100644
> --- a/drivers/watchdog/da9062_wdt.c
> +++ b/drivers/watchdog/da9062_wdt.c
> @@ -129,6 +129,8 @@ static int da9062_wdt_stop(struct watchdog_device *wdd)
> struct da9062_watchdog *wdt = watchdog_get_drvdata(wdd);
> int ret;
>
> + mdelay(DA9062_RESET_PROTECTION_MS);
> +
Please use msleep() here. A 300ms hot loop is a bit excessive.
Thanks,
Guenter
> ret = da9062_reset_watchdog_timer(wdt);
> if (ret) {
> dev_err(wdt->hw->dev, "Failed to ping the watchdog (err = %d)\n",
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
