So need info from Joel Stanley here: On Tue, Oct 10, 2017 at 9:51 PM, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote: > On Sun, Aug 27, 2017 at 7:06 PM, Guenter Roeck <linux@xxxxxxxxxxxx> wrote: >> On Thu, Aug 24, 2017 at 10:32:22PM +0200, Linus Walleij wrote: >>> On Mon, Aug 14, 2017 at 6:05 PM, Guenter Roeck <linux@xxxxxxxxxxxx> wrote: >> If I understand your comment below correctly, the driver won't work >> without clock subsystem because the clock frequency would in that case >> be 0. Why not catch that situation here, or even better make the driver >> depends on the clock subsystem ? > > OK fair enough I can do that. > > I think Aspeed is merging its clock driver this kernel cycle > so all variant SoCs actually have clocks. So when I later in the patch series convert Aspeed to use this driver we get a problem because Joel is currently working on the clock driver for Aspeed and it's not ready for merge yet as it looks. I can of course wait with the Aspeed conversion to use the common driver. Also I can slap in a fixed-rate clock in the device tree @1 MHz. But that is cheating. So I guess I rest the Aspeed conversion. Joel: does your clock patch set cover the 1MHz used by the watchdog EXTCLK? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html