On Sun, Oct 8, 2017 at 6:22 PM, Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
> On 09/26/2017 01:07 PM, Linus Walleij wrote:
>> @@ -35,11 +35,11 @@ struct gpio_wdt_priv {
>> static void gpio_wdt_disable(struct gpio_wdt_priv *priv)
>> {
>> - gpio_set_value_cansleep(priv->gpio, !priv->active_low);
>> + gpiod_set_value_cansleep(priv->gpiod, 0);
>
> This ...
Bah that's wrong. As anyone can see.
>> case HW_ALGO_LEVEL:
>> /* Pulse */
>> - gpio_set_value_cansleep(priv->gpio, !priv->active_low);
>> + gpiod_set_value_cansleep(priv->gpiod, 1);
>
>
> ... and this seem to contradict each other.
Sorry, fixing.
Thanks a lot for spotting this!
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
