On Fri, Mar 10, 2017 at 07:05:49PM +0200, Andy Shevchenko wrote:
> On Fri, 2017-03-10 at 18:51 +0200, Andy Shevchenko wrote:
> > Firmware followed by bootloader leaves watchdog running.
> >
> > Keep it running in the driver.
> >
> > User will not need any additional options to reboot in case of panic
> > during boot.
>
> > - /* Make sure the watchdog is not running */
> > - wdt_stop(wdt_dev);
> > + /*
> > + * Make sure the watchdog is serviced.
> > + *
> > + * The firmware followed by U-Boot leaves the watchdog
> > running
> > + * with the default threshold 60 seconds. Our default timeout
> > is
> > + * 90 seconds, but internal worker divides it by two, which
> > is
> > + * 45 seconds and should be enough (less by 15 seconds than
> > + * threshold).
> > + */
> > + set_bit(WDOG_HW_RUNNING, &wdt_dev->status);
>
> Giving one more thought here perhaps more robust will be to start
> watchdog unconditionally here?
>
Yes, that would be another option, and it sounds like a good idea.
Let me know if you want to do that.
Thanks,
Guenter
> In that case it will be no matter how it's configured in firmware and/or
> boot loader.
>
> >
> > ret = devm_watchdog_register_device(&pdev->dev, wdt_dev);
> > if (ret) {
>
> --
> Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
