Hi Guenter, > > +static bool nowayout = WATCHDOG_NOWAYOUT; > > +module_param(nowayout, bool, S_IRUGO); > > Sure you want this parameter readable ? No problem with me, but it is unusual, > so I figure it is worth asking. No reason, will stick to the usual case. > > +static void rwdt_write(struct rwdt_priv *priv, u32 val, unsigned reg) > > Please use 'unsigned int' throughout. Can do. May I ask why? > > + rwdt_write(priv, 65536 - wdev->timeout * priv->clks_per_sec, RWTCNT); > > + > > Just wondering, does reading RWTCNT return the remaining timeout ? > If so, you could easily implement WDIOC_GETTIMEOUT. I assume you mean GETTIMELEFT. Tried that, seems to work. > function. In other words, you can just drop rwdt_set_timeout() entirely. Cool news! Works fine. Thanks for the prompt review! Will send V2 in a minute. Wolfram -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
