Re: [PATCH v3] watchdog: ni903x_wdt: Add NI 903x/913x watchdog driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 02/22/2016 07:28 AM, Kyle Roeschley wrote:
Add support for the watchdog timer on NI cRIO-903x and cDAQ-913x real-
time controllers.

Signed-off-by: Jeff Westfahl <jeff.westfahl@xxxxxx>
Signed-off-by: Kyle Roeschley <kyle.roeschley@xxxxxx>
---
v3: Rename ni9x3x_wdt -> ni903x_wdt
     Remove 64-bit rounding workarounds
     Add WDIOF_MAGICCLOSE
     Cleanup ACPI resource walking
     Fixup acpi_add error handling
     Cleanup includes, formatting, license/copyright

v2: Rename niwatchdog -> ni9x3x_wdt
     Drop custom IOCTLs
     Remove locking, io_size, expired, running, available
     Remove all IRQ code
     Fix error handling in acpi_add
     Remove unnecessary header file

  Documentation/watchdog/watchdog-parameters.txt |   5 +
  drivers/watchdog/Kconfig                       |  11 +
  drivers/watchdog/Makefile                      |   1 +
  drivers/watchdog/ni903x_wdt.c                  | 270 +++++++++++++++++++++++++
  4 files changed, 287 insertions(+)
  create mode 100644 drivers/watchdog/ni903x_wdt.c

diff --git a/Documentation/watchdog/watchdog-parameters.txt b/Documentation/watchdog/watchdog-parameters.txt
index 9f9ec9f..df3e20e 100644
--- a/Documentation/watchdog/watchdog-parameters.txt
+++ b/Documentation/watchdog/watchdog-parameters.txt
@@ -200,6 +200,11 @@ mv64x60_wdt:
  nowayout: Watchdog cannot be stopped once started
  	(default=kernel config parameter)
  -------------------------------------------------
+ni903x_wdt:
+timeout: Intial watchdog timeout in seconds (0<timeout<516, default=60)

s/Intial/Initial/

checkpatch is your friend here.

Please fix and resubmit, and feel free to add

Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>

when you do.

Thanks,
Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux