Hello Marc, when comparing the driver drivers/watchdog/max63xx_wdt.c (in Linux 4.4) with the datasheet https://datasheets.maximintegrated.com/en/ds/MAX6369-MAX6374.pdf I wonder if I have a different documentation that you had back in 2009 when you wrote the driver. According to "my" datasheet these chips have 3 logic inputs SET1, SET2 and SET3 and depending on these the timeout is configured. In your driver however you do: wdt->base = devm_ioremap_resource(&p->dev, mem); and to select the timeout you write a byte to this address. The driver seems to be used in arch/arm/mach-ixp4xx/vulcan-setup.c and arch/arm/mach-pxa/zeus.c and I guess there the device sits behind some hardware that sets an output for each bit set in the respective register. Did I get this right? If so, a patch to extend the driver to have a binding like: { compatible = "maxim,max6371"; set-gpios = <&gpio1 12 0>, ...; wdi-gpios = <&gpio3 ...>, ...; } would be fine, right? Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
