Re: [PATCH v2] watchdog: stmp3xxx: Remove unused variables

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Fabio Estevam writes:
> Commit 8d2fa17151ea3 ("watchdog: stmp3xxx: Stop the watchdog on system
> halt") introduced the following build warning:
> 
> drivers/watchdog/stmp3xxx_rtc_wdt.c: In function 'wdt_notify_sys':
> drivers/watchdog/stmp3xxx_rtc_wdt.c:78:29: warning: unused variable 'pdata' [-Wunused-variable]
> 
> Remove the unused 'pdata' and 'dev' variables.

Looks like I made an error when splitting the original patch in two and
didn't catch it because I only tested it with the second patch together.
Sorry!
 
> Signed-off-by: Fabio Estevam <fabio.estevam@xxxxxxx>
Reviewed-by: Harald Geyer <harald@xxxxxxxxx>

Thanks.

> ---
> Changes since v1:
> - Also remove the 'dev' variable.
> 
>  drivers/watchdog/stmp3xxx_rtc_wdt.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/watchdog/stmp3xxx_rtc_wdt.c b/drivers/watchdog/stmp3xxx_rtc_wdt.c
> index dbe0372..d8b11eb 100644
> --- a/drivers/watchdog/stmp3xxx_rtc_wdt.c
> +++ b/drivers/watchdog/stmp3xxx_rtc_wdt.c
> @@ -74,9 +74,6 @@ static struct watchdog_device stmp3xxx_wdd = {
>  static int wdt_notify_sys(struct notifier_block *nb, unsigned long code,
>  			  void *unused)
>  {
> -	struct device *dev = watchdog_get_drvdata(&stmp3xxx_wdd);
> -	struct stmp3xxx_wdt_pdata *pdata = dev_get_platdata(dev);
> -
>  	switch (code) {
>  	case SYS_DOWN:	/* keep enabled, system might crash while going down */
>  		break;
> -- 
> 1.9.1
> 

-- 
If you want to support my work:
see http://friends.ccbib.org/harald/supporting/
or donate via peercoin to P98LRdhit3gZbHDBe7ta5jtXrMJUms4p7w
or bitcoin 1FUtd8T9jRN1rFz63vZz7s2fDtB6d6A7aS
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux