On 12/17/2015 04:55 PM, Li RongQing wrote:
On Thu, Dec 17, 2015 at 10:50 PM, Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
Don't bother with module_put() here.
I think this is needed;
the softdog supported soft_noreboot "Softdog action, set to 1 to
ignore reboots, 0 to reboot (default=0)"
if soft_noreboot is 1, and not call module_put(THIS_MODULE) in watchdog_fire,
softdog module ref count is leaked, and softdog will not be unload
Good point.
Guenter
-Roy
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
