On Thu, Dec 17, 2015 at 7:04 PM, Guenter Roeck <linux@xxxxxxxxxxxx> wrote: >> Signed-off-by: Li RongQing <roy.qing.li@xxxxxxxxx> > > > Real problem, wrong solution. We can not unconditionally stop all watchdogs > in the watchdog core when unregistering a watchdog. > > Do you get an error message telling you that the watchdog isn't stopped > after the echo command ? There should have been a "watchdog did not stop!" > message on the console. This is per design. Yes, I get "watchdog did not stop!" > > The problem here is that the softdog has static variables which are accessed > if its timer is still running after the driver is unloaded. This is a > problem > in the softdog driver, not in the watchdog core. > > The softdog driver should refuse to unload while still running. Anything > else would defeat the purpose of MAGICCLOSE and the requirement to write > the magic character before closing the watchdog. Ok, I will resend a patch as you suggested thanks -Roy > > Thanks, > Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
