On 24.11.2015 08:36, Guenter Roeck wrote: > On 11/20/2015 11:11 PM, Vladimir Zapolskiy wrote: >> Ping watchdog pretimeout governor, on watchdog pretimeout event ping >> watchdog device. Use this watchdog pretimeout governor with caution, >> it may humiliate watchdog work, however it may be helpful in some >> particular situations, for instance if once started watchdog can not >> be stopped, but reboot caused by the watchdog is undesired. >> >> Signed-off-by: Vladimir Zapolskiy <vladimir_zapolskiy@xxxxxxxxxx> >> --- >> drivers/watchdog/Kconfig | 16 +++++++++++++ >> drivers/watchdog/Makefile | 1 + >> drivers/watchdog/pretimeout_ping.c | 48 ++++++++++++++++++++++++++++++++++++++ >> 3 files changed, 65 insertions(+) >> create mode 100644 drivers/watchdog/pretimeout_ping.c >> >> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig >> index 6c1f7e1..cb0885a 100644 >> --- a/drivers/watchdog/Kconfig >> +++ b/drivers/watchdog/Kconfig >> @@ -1669,6 +1669,12 @@ config WATCHDOG_PRETIMEOUT_DEFAULT_GOV_DEVICE >> Use device specific watchdog pretimeout event handler >> by default. >> >> +config WATCHDOG_PRETIMEOUT_DEFAULT_GOV_PING >> + bool "ping" >> + select WATCHDOG_PRETIMEOUT_GOV_PING >> + help >> + Use ping watchdog pretimeout event handler by default. >> + >> endchoice >> >> config WATCHDOG_PRETIMEOUT_GOV_NOOP >> @@ -1698,6 +1704,16 @@ config WATCHDOG_PRETIMEOUT_GOV_DEVICE >> does nothing, if watchdog driver does not define a pretimeout >> callback. >> >> +config WATCHDOG_PRETIMEOUT_GOV_PING >> + tristate "Ping watchdog pretimeout governor" >> + help >> + Ping watchdog pretimeout governor, on watchdog pretimeout >> + event ping watchdog device. Use this watchdog pretimeout >> + governor with caution, it may humiliate watchdog work, >> + however it may be helpful in some particular situations, >> + for instance if once started watchdog can not be stopped, >> + but reboot caused by the watchdog is undesired. >> + > > This one will be unnecessary once the pending infrastructure enhancements > are accepted. The watchdog core will then handle the ping. > I don't think this should be left to user space, as it _would_ defeat > the watchdog's purpose if the watchdog application fails to ping > the watchdog. > Ok, I'll drop it. -- With best wishes, Vladimir -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
