On 11/09/2015 11:20 PM, Uwe Kleine-König wrote:
Hello Guenter,
On Mon, Nov 09, 2015 at 03:19:48PM -0800, Guenter Roeck wrote:
On 11/09/2015 11:02 AM, Uwe Kleine-König wrote:
On Mon, Nov 09, 2015 at 07:19:09AM -0800, Guenter Roeck wrote:
On 11/09/2015 01:55 AM, Alexander Stein wrote:
This notifier is required when the watchdog is configured as always running
because in this case the watchdog will be triggered when the kernel panics
at boot before any application could open the device, e.g. because the
rootfs is broken. This should result in a resetting system. Thus we
register a panic notifier which stops triggering the watchdog.
Shouldn't the timer be stopped instead ?
What do you mean saying "timer"? The hardware? This might or might not
be possible.
I meant the timer referenced with the variable 'timer' in struct
gpio_wdt_priv, and "stop timer' would translate to somoething like
'mod_timer(&priv->timer, 0);'.
Sorry for not being more specific.
My feeling is that improving the gpio-wdt driver is the wrong way. I
admit I lost track of the patch series that moves that handling into the
watchdog core, what is the status here? There thinking more accurately
I got no further review comments, so it is stalled.
I think I may resubmit after -rc1 is out and then just ask Wim to accept
the series. I think it is in good enough shape that we can fix any left-over
problems (if any) separately.
Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
