On 21/08/2015:10:13:36 AM, Guenter Roeck wrote: > On Fri, Aug 21, 2015 at 10:35:37PM +0530, Pratyush Anand wrote: > > On 21/08/2015:08:19:03 AM, Guenter Roeck wrote: > > > On Fri, Aug 21, 2015 at 02:22:17PM +0530, Pratyush Anand wrote: > > > > On 18/08/2015:07:23:38 AM, Guenter Roeck wrote: > > > > > Sounds good. We should have a 'name' attribute as well. We'll also need > > > > > 'timeout', 'keepalive' to ping the watchdog, 'timeleft', and 'bootstatus'. > > > > > Not sure what else. > > > > > > > > > > The attributes should be implemented as class attributes, to ensure > > > > > that they are created and removed automatically. That may require > > > > > the watchdog class to be static instead of a pointer. > > > > > > > > Should n't attributes be implemented as device attribute as they are properties > > > > of each device. Under the class watchdog_class, we can have multiple device on a > > > > system, and these attributes would be different for different devices. So, what > > > > I am thinking is to create device in __watchdog_register_device using > > > > device_create_with_groups instead of device_create. Here we can link a > > > > attribute_group with all attributes you suggested. > > > > > > > Class attibutes are created automatically for each device registered which is > > > a member of the class. They are attached to the device, not to the class. > > > > Not sure, if we both are referring to same thing.. > > So, I did a basic testing. I changed "static struct class *watchdog_class;" to "tatic > > struct class watchdog_class" and other than .name and .owner I added > > .class_attrs and then further added one node "state" in this class_attrs. > > > If you use .dev_groups instead of .class_attrs it should work. OK.. Got it..Thanks for this info. I see another issue with that. I will have to make watchdog_class as global. Let me send my RFC patch, which will be very soon and then may be we can see if some improvement can be done further. ~Pratyush -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
