On Mon, 27 Jul, at 07:24:09AM, Guenter Roeck wrote: > On 07/27/2015 07:19 AM, Matt Fleming wrote: > >On Mon, 27 Jul, at 06:49:08AM, Guenter Roeck wrote: > >> > >>I don't see the platform data freed anywhere, neither in the error path nor > >>in the cleanup path of this driver. Can you use devm_kzalloc() ? > >>Otherwise I think you'll need a cleanup path. > > > >Oops, good catch. Yes, devm_kzalloc() can be used here, thanks! > > > Or maybe just use a static data structure, like in the i2c driver. The point of dynamically allocating it is that we can use the data from the static lpc_ich_chipset_info array and munge into the correct platform data. The alternative would be to go and mass-modify that array to include iTCO_wdt_platform_data objects that we could directly pass to the iTCO_wdt driver. I wanted to avoid the code churn, but I'm not super bothered either way if people have strong opinions about it. -- Matt Fleming, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
