Hi,
On 07/20/2015 10:26 AM, Maxime Ripard wrote:
Hi Francesco,
Your patch looks mostly good, but there's just a few minor things.
On Mon, Jul 06, 2015 at 07:59:39PM +0200, Francesco Lavra wrote:
Commit f2147de3 ("watchdog: sunxi: support parameterized compatible
The commit ID should have at least 12 chars to avoid future ID
collisions (which already start to happen)
Will do.
strings") introduced a regression in sunxi_wdt_start(), by which
the system reset function of the watchdog is not enabled upon
starting the watchdog. Fix it.
Having a description of what that actually means for the end-user (I
guess that it won't reset the system when the watchdog expires) would
be nice.
Fair enough.
Signed-off-by: Francesco Lavra <francescolavra.fl@xxxxxxxxx>
Could you also CC stable, and add a Fixes: tag please?
Sure, a V2 patch will follow shortly.
Thanks,
Maxime
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
