Hi Francesco,
Your patch looks mostly good, but there's just a few minor things.
On Mon, Jul 06, 2015 at 07:59:39PM +0200, Francesco Lavra wrote:
> Commit f2147de3 ("watchdog: sunxi: support parameterized compatible
The commit ID should have at least 12 chars to avoid future ID
collisions (which already start to happen)
> strings") introduced a regression in sunxi_wdt_start(), by which
> the system reset function of the watchdog is not enabled upon
> starting the watchdog. Fix it.
Having a description of what that actually means for the end-user (I
guess that it won't reset the system when the watchdog expires) would
be nice.
> Signed-off-by: Francesco Lavra <francescolavra.fl@xxxxxxxxx>
Could you also CC stable, and add a Fixes: tag please?
Thanks,
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
Attachment:
signature.asc
Description: Digital signature
