Re: [PATCH 1a/3] watchdog: omap: clearify device tree documentation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Apr 26, 2015 at 08:29:20AM -0700, Guenter Roeck wrote:
> On 04/24/2015 07:10 PM, Felipe Balbi wrote:
> >On Fri, Apr 24, 2015 at 10:20:50PM +0200, Uwe Kleine-König wrote:
> >>ti,hwmods doesn't belong into the compatible section but is a property
> >>on it's own. Also reformat the section of required properties to match the
> >>usual style of dt binding documents.
> >>
> >>Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> >
> >looks great to me, thanks
> >
> >Reviewed-by: Felipe Balbi <balbi@xxxxxx>
> >Acked-by: Felipe Balbi <balbi@xxxxxx>
> >
> 
> Reviewed-by: and Acked-by: are mutually exclusive.
Really? Acked means you like it and Reviewed by means you looked deeper
into it. Maybe reviewing without liking isn't likely, *shrug*.

The command

	$ git rev-list linus/master | while read cmmt; do git cat-file commit $cmmt | awk -v cmmt=$cmmt '$1 ~ /(Acked|Reviewed)-by:/ { $1 = ""; print cmmt " " $0 }' | sort; done | uniq -d

should catch all commits that have duplicate tags. There are a few,
*shrugagain*.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux