On 04/25/2015 01:11 PM, Arnd Bergmann wrote:
On Friday 24 April 2015 12:08:54 Eric Anholt wrote:+/* + * We can't really power off, but if we do the normal reset scheme, and + * indicate to bootcode.bin not to reboot, then most of the chip will be + * powered off. + */ +static void bcm2835_power_off(void) +{ + struct device_node *np = + of_find_compatible_node(NULL, NULL, "brcm,bcm2835-pm-wdt"); + struct platform_device *pdev = of_find_device_by_node(np); + struct bcm2835_wdt *wdt = platform_get_drvdata(pdev); + u32 val; +Instead of doing the lookup again here, I'd suggest using a static variable in the driver to store the device pointer for the device used on power_off. Make sure that the device remove callback assigns it back to NULL though and that the function checks for NULL pointer.
Why would that be needed ? Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
