Hi Markus, Thanks for your work. And there has already one patch for this: "watchdog: imx2_wdt: Convert to use regmap framework's endianness method." Thanks, BRs Xiubo > -----Original Message----- > From: Markus Pargmann [mailto:mpa@xxxxxxxxxxxxxx] > Sent: Monday, August 25, 2014 2:44 PM > To: Wim Van Sebroeck > Cc: linux-watchdog@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; > kernel@xxxxxxxxxxxxxx; Markus Pargmann; Xiubo Li-B47053 > Subject: [PATCH] watchdog: imx2_wdt: Remove seperate big endian handling > > 3.18 will contain a patch that handles endianess within the regmap > framework. It does not need any parsing of DT properties within the > driver, so we can savely remove it here. > The required mainline patch is > (regmap: add DT endianness binding support.) > > Cc: Xiubo Li <Li.Xiubo@xxxxxxxxxxxxx> > Signed-off-by: Markus Pargmann <mpa@xxxxxxxxxxxxxx> > --- > Hi, > > This is the topic branch with the patches which replace the functionality of > this code. > https://git.kernel.org/cgit/linux/kernel/git/broonie/regmap.git/log/?h=topic/d > t-endian > > Best regards, > > Markus > > > drivers/watchdog/imx2_wdt.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/watchdog/imx2_wdt.c b/drivers/watchdog/imx2_wdt.c > index 68c3d379ffa8..9d4874f09948 100644 > --- a/drivers/watchdog/imx2_wdt.c > +++ b/drivers/watchdog/imx2_wdt.c > @@ -28,7 +28,6 @@ > #include <linux/kernel.h> > #include <linux/module.h> > #include <linux/moduleparam.h> > -#include <linux/of_address.h> > #include <linux/platform_device.h> > #include <linux/regmap.h> > #include <linux/timer.h> > @@ -191,12 +190,10 @@ static struct regmap_config imx2_wdt_regmap_config = { > > static int __init imx2_wdt_probe(struct platform_device *pdev) > { > - struct device_node *np = pdev->dev.of_node; > struct imx2_wdt_device *wdev; > struct watchdog_device *wdog; > struct resource *res; > void __iomem *base; > - bool big_endian; > int ret; > u32 val; > > @@ -204,10 +201,6 @@ static int __init imx2_wdt_probe(struct platform_device > *pdev) > if (!wdev) > return -ENOMEM; > > - big_endian = of_property_read_bool(np, "big-endian"); > - if (big_endian) > - imx2_wdt_regmap_config.val_format_endian = REGMAP_ENDIAN_BIG; > - > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > base = devm_ioremap_resource(&pdev->dev, res); > if (IS_ERR(base)) > -- > 2.1.0.rc1 -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
