Re: [v4] watchdog: Add DA906x PMIC watchdog driver.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Thu, Aug 21, 2014 at 07:19:59AM -0700, Guenter Roeck wrote:
> On Thu, Aug 21, 2014 at 08:15:25AM +0200, Markus Pargmann wrote:
> > Hi,
> > 
> ...
> > > > +static int da9063_wdt_timeout_to_sel(int secs)
> > > > +{
> > > > +	int i;
> > > > +
> > > > +	for (i = DA9063_TWDSCALE_MIN; i <= DA9063_TWDSCALE_MAX; i++) {
> > > 
> > > When building with W=1, gcc complains about this line. Would be great if you can
> > > have a look and fix it.
> > 
> > I just compiled with W=1, it doesn't complain here about this line.
> > Could you give me the warning?
> > 
> drivers/watchdog/da9063_wdt.c: In function 'da9063_wdt_timeout_to_sel':
> drivers/watchdog/da9063_wdt.c:48:34: warning: comparison between signed and
> unsigned integer expressions [-Wsign-compare]
> 
> This is with arm-poky-linux-gnueabi-gcc (GCC) 4.7.2.

Thanks, I am using gcc 4.8.3. I replaced the used 'int' type by 'unsigend
int', that should fix it.

Best regards,

Markus

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux