On 08/14/2014 02:57 AM, Markus Pargmann wrote:
+
+static int da9063_wdt_probe(struct platform_device *pdev)
+{
+ int ret;
+ struct da9063 *da9063 = dev_get_drvdata(pdev->dev.parent);
+ struct da9063_watchdog *wdt;
+
+ if (!da9063)
+ return -EPROBE_DEFER;
Can this ever happen ? Isn't this driver instantiated from its parent,
which would ensure that the parent's driver data is set ?
No this can't happen. I replaced it with BUG_ON and also introduced a
BUG_ON check for dev.parent.
That is a bit too much. You should only use BUG_ON if the kernel can not
continue to run, which should not be the case here. I would suggest
to return -ENODEV.
Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
