On 07/17/2014 05:16 PM, Dan Carpenter wrote: > On Thu, Jul 17, 2014 at 04:59:09PM +0800, Chen Gang wrote: >>>> + return (__force void __iomem *)ERR_PTR(-ENXIO); >>> >>> There's apparently an IOMEM_ERR_PTR() for this nowadays... >>> >> >> IOMEM_ERR_PTR() is defined within "lib/devres.c", not in "./include". >> But may we move it from "lib/devres.c" to "./include/linux/err.h"? >> >> For me, I am not quite sure, it may need additional discussion, but at >> least, that will be another patch. > > Yes. Move it there. That is the right place. > OK, thanks, if no another objections within 2 days, I shall send another related patch for it. Thanks. -- Chen Gang Open, share, and attitude like air, water, and life which God blessed -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html