On Mon 16-06-14 16:52:45, Don Zickus wrote: [...] > Michal, do you remember why we needed preempt here? I wouldn't think it > mattered as we are not doing anything per-cpu specific. Yes, you are right. Preempt can be enabled because we are always accessing watchdog_ev on a specific cpu so reschedule doesn't matter. > Cheers, > Don > > diff --git a/kernel/watchdog.c b/kernel/watchdog.c > index 516203e..30e4822 100644 > --- a/kernel/watchdog.c > +++ b/kernel/watchdog.c > @@ -527,10 +527,8 @@ static void update_timers_all_cpus(void) > int cpu; > > get_online_cpus(); > - preempt_disable(); > for_each_online_cpu(cpu) > update_timers(cpu); > - preempt_enable(); > put_online_cpus(); > } > -- Michal Hocko SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
