Hi,
On 05/11/2012 06:02 PM, Wim Van Sebroeck wrote:
Hi Hans,
+ if (id != 0)
+ return ret;
I believe the check above should be:
if (id != 0 || ret != -EBUSY)
return ret;
IOW we should not retry the registration if it failed for another reason
then the id already being taken by a legacy driver.
Than for readibility we should say:
if (!(id == 0&& ret == -EBUSY))
return ret
ACK.
Regards,
Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html