Re: [PATCH 1/4] watchdog: Add multiple device support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Hans,

> >+		if (id != 0)
> >+			return ret;
> 
> 
> I believe the check above should be:
> 		if (id != 0 || ret != -EBUSY)
> 			return ret;
> 
> IOW we should not retry the registration if it failed for another reason
> then the id already being taken by a legacy driver.

Than for readibility we should say:
		if (!(id == 0 && ret == -EBUSY))
			return ret

Kind regards,
Wim.

--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux