On Wed, Mar 07, 2012 at 04:37:12AM -0800, viresh kumar wrote: > On 3/7/12, Russell King - ARM Linux <linux@xxxxxxxxxxxxxxxx> wrote: > > Drivers have no business interpreting anything but an IS_ERR() return from > > clk_get() as invalid. Everything else is the CLK APIs business, not the > > driver's business. So, to start using NULL as a special case is wrong. > > But driver isn't comparing return value of clk_get with NULL (that would have > been wrong) or interpreting its return value in a wrong way. What if clk_get() returned NULL? Hint: as far as _you_ are concerned as a driver writer, a struct clk is an opaque cookie. IS_ERR(clk) means the cookie is invalid. Everything else is potentially valid. You must not interpret anything which is potentially valid as some kind of special case. > Instead it is using the same pointer/variable to check if clk_* APIs are > supported or not by making it NULL. And that's a driver convention. Bollocks it is. Plain and simple NAK to this patch until clue is forthcoming. -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
