On 3/7/12, Russell King - ARM Linux <linux@xxxxxxxxxxxxxxxx> wrote: > Drivers have no business interpreting anything but an IS_ERR() return from > clk_get() as invalid. Everything else is the CLK APIs business, not the > driver's business. So, to start using NULL as a special case is wrong. But driver isn't comparing return value of clk_get with NULL (that would have been wrong) or interpreting its return value in a wrong way. Instead it is using the same pointer/variable to check if clk_* APIs are supported or not by making it NULL. And that's a driver convention. I still believe it is fine. Thanks for your quick comments. -- viresh -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html