On 07/11/2011 11:32 PM, Wolfram Sang wrote: >> +int watchdog_register_device(struct watchdog_device *wdd) >> +{ >> + int ret; >> + >> + /* Make sure we have a valid watchdog_device structure */ >> + if (wdd == NULL || wdd->info == NULL || wdd->ops == NULL) >> + return -EINVAL; >> + >> + /* Make sure that the mandatory operations are supported */ >> + if (wdd->ops->start == NULL || wdd->ops->stop == NULL) >> + return -EINVAL; > > Check also for wdd->ops->owner? Should we mark it as mandatory? > If the driver is built-in owner will be NULL. -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html