On Thu, Jun 02, 2011 at 02:54:20PM +0200, Florian Fainelli wrote:
> Otherwise, the gpiolib autorequest feature will produce a WARN_ON():
>
> WARNING: at drivers/gpio/gpiolib.c:101 0x8020ec6c()
> autorequest GPIO-215
> [...]
>
> CC: stable@xxxxxxxxxx
> Signed-off-by: Florian Fainelli <florian@xxxxxxxxxxx>
> ---
> diff --git a/drivers/watchdog/mtx-1_wdt.c b/drivers/watchdog/mtx-1_wdt.c
> index 63df28c..16086f8 100644
> --- a/drivers/watchdog/mtx-1_wdt.c
> +++ b/drivers/watchdog/mtx-1_wdt.c
> @@ -214,6 +214,11 @@ static int __devinit mtx1_wdt_probe(struct platform_device *pdev)
> int ret;
>
> mtx1_wdt_device.gpio = pdev->resource[0].start;
> + ret = gpio_request(mtx1_wdt_device.gpio, "mtx1-wdt");
> + if (ret < 0) {
> + dev_err(&pdev->dev, "failed to request gpio");
> + return ret;
> + }
Could you use gpio_request_one() here to make sure the GPIO is in the
correct direction first?
Jamie
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
