Re: [PATCHv1 -next] WATCHDOG: Watchdog module of DA9052 device driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Ashish, David,

Driver looks OK at first glance. Will look at it some more later this week.

> +static int __devexit da9052_sm_remove(struct platform_device *dev)
> +{
> +       misc_deregister(&da9052_wdt_miscdev);
> +       strobe_interval = 0;
> +       strobe_mode = 0;
> +       return 0;
> +}

Small remark: here I am missing a kfree(wdt);

Kind regards,
Wim.

--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux