Hi Wim,
some questions inline
>> +ltq_wdt_disable(void)
>> +{
>> +#ifndef CONFIG_WATCHDOG_NOWAYOUT
>> + ltq_wdt_ok_to_close = 0;
>> +#endif
>> + /* write the first password magic */
>> + ltq_w32(LTQ_WDT_PW1, ltq_wdt_membase + LTQ_WDT_CR);
>> + /* write the second password magic with no config
>> + * this turns the watchdog off
>> + */
>> + ltq_w32(LTQ_WDT_PW2, ltq_wdt_membase + LTQ_WDT_CR);
>> +}
>>
> Don't like this ifdef/ifndef stuff. The nowayout things can be done in the /dev/watchdog handling.
>
>
Sorry i am not sure what you mean by "can be done in the /dev/watchdog
handling". could you be so kind and elaborate.
looking at some of the other drivers, there seem to be 2 strategies for
this.
1) using the #ifdef
2) using a module parameter
do you mean the later ?
> Please add the code to make sure that /dev/watchdog can be opened once.
>
>
Do you mean "only" once ?
thanks for the clarification,
John
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
