On Wed, Jan 12, 2011 at 02:27:47PM +0530, viresh kumar wrote: > > I think this is right, it's perfectly valid for a platform to return > > NULL as a clk and you can pass that to clk_enable(). > > > > I agree on the first part: NULL can be returned from clk_get(), but > passing NULL to clk_enable and clk_get_rate doesn't look fine to me. Whatever non-error cookie clk_get() passes out, clk_enable() etc must eat, even if it contains dead flies rather than currants. It's not for the driver to make decisions on what clk_enable() et.al. accept, other than as documented by the clk API - which says that errors from clk_get() are indicated by IS_ERR(clk). If IS_ERR(clk) is false, the driver _must_ assume that there is no error and clk_enable() etc will accept the clk. -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
