On Wed, 11 Sep 2024 12:30:49 -0700, "Si-Wei Liu" <si-wei.liu@xxxxxxxxxx> wrote: > > > On 9/11/2024 7:22 AM, Michael S. Tsirkin wrote: > > Thanks a lot! > > Could you retest Xuan Zhuo original patch > Which one? I thought Darren already did so? This one[1]. Now, we revert these patches to disable premapped mode by default. But the bug still exists, if we enable the premapped mode manually, the bug works again. [1] was attempted to correct the bug. However, Darren reported that it did not work. On the other hand, Jason, Takero, and me tested it and found that it worked for we. So I ask Darren to retest [1] if he has the time. [1].http://lore.kernel.org/all/20240820071913.68004-1-xuanzhuo@xxxxxxxxxxxxxxxxx Thanks. > > -Siwei > > just to make sure it does > > not fix the issue? > > > > On Wed, Sep 11, 2024 at 03:18:55PM +0100, Darren Kenny wrote: > >> For the record, I got a chance to test these changes and confirmed that > >> they resolved the issue for me when applied on 6.11-rc7. > >> > >> Tested-by: Darren Kenny <darren.kenny@xxxxxxxxxx> > >> > >> Thanks, > >> > >> Darren. > >> > >> PS - I'll try get to looking at the other potential fix when I have time. > >> > >> On Tuesday, 2024-09-10 at 08:12:06 -04, Michael S. Tsirkin wrote: > >>> On Fri, Sep 06, 2024 at 08:31:34PM +0800, Xuan Zhuo wrote: > >>>> Regression: http://lore.kernel.org/all/8b20cc28-45a9-4643-8e87-ba164a540c0a@xxxxxxxxxx > >>>> > >>>> I still think that the patch can fix the problem, I hope Darren can re-test it > >>>> or give me more info. > >>>> > >>>> http://lore.kernel.org/all/20240820071913.68004-1-xuanzhuo@xxxxxxxxxxxxxxxxx > >>>> > >>>> If that can not work or Darren can not reply in time, Michael you can try this > >>>> patch set. > >>> Just making sure netdev maintainers see this, this patch is for net. > >>> > >>>> Thanks. > >>>> > >>>> Xuan Zhuo (3): > >>>> Revert "virtio_net: rx remove premapped failover code" > >>>> Revert "virtio_net: big mode skip the unmap check" > >>>> virtio_net: disable premapped mode by default > >>>> > >>>> drivers/net/virtio_net.c | 95 +++++++++++++++++++--------------------- > >>>> 1 file changed, 46 insertions(+), 49 deletions(-) > >>>> > >>>> -- > >>>> 2.32.0.3.g01195cf9f >
