> From: Lu Baolu <baolu.lu@xxxxxxxxxxxxxxx> > Sent: Tuesday, April 30, 2024 10:57 PM > > Previously, the domain that a page fault targets is stored in an > iopf_group, which represents a minimal set of page faults. With the > introduction of attachment handle, replace the domain with the handle It's better to use 'attach handle' as the code does. > + handle = iommu_attach_handle_get(dev->iommu_group, pasid, 0); > + if (IS_ERR(handle)) > + return PTR_ERR(handle); > > - if (!domain || !domain->iopf_handler) { > - dev_warn_ratelimited(dev, > - "iopf (pasid %d) without domain attached or handler > installed\n", > - fault->prm.pasid); > + group->attach_handle = handle; > + group->domain = handle->domain; this change also removes the warning message. Is it desired?