Re: [PATCH] ifcvf/vDPA: ifcvf drives standard virtio pci devices

["Zhu, Lingshan" <lingshan.zhu@xxxxxxxxx>]

On 5/14/2024 9:44 PM, Michael S. Tsirkin wrote:
> On Tue, May 14, 2024 at 05:27:07AM +0800, Zhu Lingshan wrote:
> > @@ -880,7 +881,9 @@ static struct pci_device_id ifcvf_pci_ids[] = {
> >   			 VIRTIO_TRANS_ID_BLOCK,
> >   			 PCI_VENDOR_ID_INTEL,
> >   			 VIRTIO_ID_BLOCK) },
> > -
> > +	/* standard virtio pci devices */
> > +	{ PCI_DEVICE(PCI_VENDOR_ID_REDHAT_QUMRANET,
> > +		     PCI_ANY_ID) },
> >   	{ 0 },
>
> To summarize, I don't think ifcvf should drive standard virtio devices.
> If it can then it sounds more like a reason to try to reuse more code
> from virtio core.
Yeah, OK.
By the way, I send out a V2 of MAINTAINER patch only changing my
email address to kernel.org.
> >   };
> >   MODULE_DEVICE_TABLE(pci, ifcvf_pci_ids);
> > --
> > 2.43.0